Page MenuHomePhabricator

bindpProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Recent Activity

Nov 21 2017

Patrick added a comment to T688: Change bindp compile to postinstall.

https://github.com/Whonix/bindp/commit/d7052e58d57b2d8a5f54dab2e6da836d3fb61ce8

Nov 21 2017, 6:18 PM · bindp, Whonix 14, Whonix

Jul 9 2017

Patrick closed T688: Change bindp compile to postinstall as Resolved.

The diff looked very weird. Somehow you reverted to an earlier version of bindp.c. Fixed in master.

Jul 9 2017, 2:31 PM · bindp, Whonix 14, Whonix
JasonJAyalaP added a comment to T688: Change bindp compile to postinstall.
git clone git@github.com:Whonix/bindp.git
cd bindp
git checkout bindppost
make deb-icup

If the goal is simply put the libindp.so file into /usr/lib, I think I was successful. @Patrick If it tests fine for you, please merge to master and close this ticket.

Jul 9 2017, 12:02 AM · bindp, Whonix 14, Whonix

Jul 8 2017

Patrick added a comment to T688: Change bindp compile to postinstall.

JasonJAyalaP (Jason J. Ayala P.):

It doesn't remove the .c file.

Jul 8 2017, 7:35 PM · bindp, Whonix 14, Whonix
Patrick added a comment to T688: Change bindp compile to postinstall.
There was a dh-helper warning. Something about #dh-helper# token not being in bindp.postinst. I'm not what to do there.
Jul 8 2017, 7:34 PM · bindp, Whonix 14, Whonix
Patrick added a comment to T688: Change bindp compile to postinstall.

JasonJAyalaP (Jason J. Ayala P.):

JasonJAyalaP added a comment.

https://github.com/Whonix/bindppost
Jul 8 2017, 12:31 PM · bindp, Whonix 14, Whonix
JasonJAyalaP added a comment to T688: Change bindp compile to postinstall.
git clone git@github.com:Whonix/bindppost.git
cd bindppost
make deb-icup
Jul 8 2017, 3:54 AM · bindp, Whonix 14, Whonix

Jul 3 2017

s.sh added a comment to T599: bindp libindp.so C code fixes.

A miracle has happened. All of https://github.com/yongboy/bindp/pull/6 was merged by upstream.

Very well. So finally they applied our patch.

Jul 3 2017, 8:55 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.
In T599#12631, @Patrick wrote:

Notified upstream. Let's see if he replies.
bindp pull request - security fixes, debian packaging, and more:
https://github.com/yongboy/bindp/pull/6

Jul 3 2017, 1:52 PM · bindp, security, Whonix 14, C Code, Whonix

Jun 16 2017

HulaHoop added a comment to T688: Change bindp compile to postinstall.

Agreed. If they really want to stick to i686 then they can if they know what they are doing. Otherwise I don't think its a good use of time to support this officially. especially with the recent changes for the KVM version where its just easier to delete and start over.

Jun 16 2017, 9:15 PM · bindp, Whonix 14, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

What about...?

Jun 16 2017, 8:21 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

What about...?

Jun 16 2017, 8:16 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.
In T599#13705, @Patrick wrote:

Now pushed.

Jun 16 2017, 7:47 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Now pushed.

Jun 16 2017, 7:01 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick In the master branch the only difference in comparison to the original version that I can see is the main function at the bottom of the file. Did you not apply the changes? This code is still the previous one.

Jun 16 2017, 6:15 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T688: Change bindp compile to postinstall.

Btw this ticket will probably result in users of Non-Qubes-Whonix 13 (i686) being able to upgrade to Non-Qubes-Whonix 14. @HulaHoop

Jun 16 2017, 5:48 PM · bindp, Whonix 14, Whonix
Patrick added a comment to T688: Change bindp compile to postinstall.

Due to T599#13695...

Jun 16 2017, 5:43 PM · bindp, Whonix 14, Whonix
Patrick closed T599: bindp libindp.so C code fixes as Resolved.

Merged into master.

Jun 16 2017, 5:41 PM · bindp, security, Whonix 14, C Code, Whonix

Jun 15 2017

JasonJAyalaP added a comment to T688: Change bindp compile to postinstall.

For reference, the (relevant, i think) flags that bindp make currently uses:

Jun 15 2017, 10:26 PM · bindp, Whonix 14, Whonix

Jun 5 2017

Patrick triaged T688: Change bindp compile to postinstall as Normal priority.
Jun 5 2017, 9:34 PM · bindp, Whonix 14, Whonix

Mar 26 2017

Patrick reopened T599: bindp libindp.so C code fixes as "Open".
Mar 26 2017, 1:53 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick closed T599: bindp libindp.so C code fixes as Resolved.
Mar 26 2017, 12:56 PM · bindp, security, Whonix 14, C Code, Whonix

Mar 10 2017

s.sh added a comment to T599: bindp libindp.so C code fixes.

Do you see any things a malicious application could to gain arbitrary code execution through bindp?

Mar 10 2017, 11:55 AM · bindp, security, Whonix 14, C Code, Whonix

Mar 9 2017

Patrick added a comment to T599: bindp libindp.so C code fixes.

Notified upstream. Let's see if he replies.

Mar 9 2017, 7:35 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Functionally speaking, as I tested, it works great in Whonix. Pretty much done.

Mar 9 2017, 7:19 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick Do you have anything else from this project remained that needs extra working on ?

Mar 9 2017, 5:49 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Works for me!

Mar 9 2017, 5:40 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick Updated: http://pastebin.com/9XcTZwVG

Mar 9 2017, 4:58 PM · bindp, security, Whonix 14, C Code, Whonix

Mar 8 2017

Patrick added a comment to T599: bindp libindp.so C code fixes.
Onionshare 0.9.1 | https://onionshare.org/
[-] LIB received AF_INET bind request
[-] Changing 127.0.0.1 to 10.137.11.80
[-] AF_INET: Leaving port unchanged
[!] connect(): AF_INET connect() call
[-] LIB received AF_INET bind request
[-] Changing 127.0.0.1 to 10.137.11.80
[-] AF_INET: Leaving port unchanged
[!] connect(): AF_INET connect() call
[-] LIB received AF_INET bind request
[-] Changing 127.0.0.1 to 10.137.11.80
[-] AF_INET: Leaving port unchanged
[!] connect(): AF_INET connect() call
[-] LIB received AF_INET bind request
[-] Changing 127.0.0.1 to 10.137.11.80
[-] AF_INET: Leaving port unchanged
Can't connect to Tor control port on port [9151, 9153, 9051]. OnionShare requires Tor Browser to be running in the background to work. If you don't have it you can get it from https://www.torproject.org/.
Mar 8 2017, 11:40 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick I need more debug info, I suspect the connect function is causing trouble.
Please use this and send the output again: http://pastebin.com/BZqTRBTc

Mar 8 2017, 11:05 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Added that. And added some intent style changes. Please tell me if my C intent style is actually making things non-standard / worse than before.

Mar 8 2017, 10:48 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick
Code fixed. Please check and use this: http://pastebin.com/GvDpuC0f

Mar 8 2017, 8:37 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.
In T599#12621, @Patrick wrote:

Why did you add #ifdef SO_REUSEPORT?

Mar 8 2017, 7:27 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Why did you add #ifdef SO_REUSEPORT?

Mar 8 2017, 3:54 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

Well the segfault error is strange here, I must run it locally with your setup to check and debug which is not possible for now, but it's good you made it work finally. Good job Patrick. Still I think PIE related options are not needed for libraries.
I will modify the code by tonight and send the new revisions.

Mar 8 2017, 7:22 AM · bindp, security, Whonix 14, C Code, Whonix

Mar 7 2017

Patrick added a comment to T599: bindp libindp.so C code fixes.

It's functional! Successfully changes the listener IP.

Mar 7 2017, 11:00 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Did that.

Mar 7 2017, 10:58 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

no segfault:

Mar 7 2017, 10:51 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

That's great! Thank you for your help! Just now tested. Unfortunately it does not work.

Mar 7 2017, 10:35 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick Nice, now regular testing needs to be done from your side, please keep in mind that connect function has to change as well, but before that I must assure that current bind() works properly and as expected. If everything goes well I will write whole code from scratch for you by modifying init and connect functions.

Mar 7 2017, 8:14 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Did that.

Mar 7 2017, 4:55 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick Add

Mar 7 2017, 2:18 PM · bindp, security, Whonix 14, C Code, Whonix

Mar 6 2017

s.sh added a comment to T599: bindp libindp.so C code fixes.

What does DSO mean?

Mar 6 2017, 9:48 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

Can we have all hardening with PIE enabled as well as without ld warning?

Mar 6 2017, 9:36 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.
In T599#12601, @s.sh wrote:

But these warnings are not related to my revisions, they probably existed in original code.

Mar 6 2017, 9:27 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick You can compile without -fPIE (I think -fPIC is enough):

Mar 6 2017, 9:03 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.
In T599#12599, @s.sh wrote:

@Patrick Add

#include <arpa/inet.h>

at the beginning of the file.

Mar 6 2017, 8:46 PM · bindp, security, Whonix 14, C Code, Whonix
s.sh added a comment to T599: bindp libindp.so C code fixes.

@Patrick Add

#include <arpa/inet.h>
Mar 6 2017, 8:41 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

Do you know how to fix these compiler warning?

Mar 6 2017, 8:38 PM · bindp, security, Whonix 14, C Code, Whonix
Patrick added a comment to T599: bindp libindp.so C code fixes.

one more stylistic fix:

Mar 6 2017, 8:24 PM · bindp, security, Whonix 14, C Code, Whonix