Page MenuHomePhabricator

mediawiki fixes #3
Open, NormalPublic

Description

merge template footer into real footer

  • This is the "template footer". (for lack of better term)
  • This is the real footer:

This page was last edited on 25 January 2020, at 11:42.
Imprint Privacy Policy Cookie Policy Terms of Service DMCA E-Sign Consent Priority Support Investors Professional Support

Mediawiki doesn't support to put arbitrary text into the footer. Problem with template footer is that it needs to be added to every wiki page at the bottom with {{Footer}} and that it does not show up on special pages. Therefore some footer links are duplicated.

Could html be included into CSS (other way around)? Or could the footer CSS somehow pull the footer html?


remove blockquote extraneous newlines

  • See https://www.whonix.org/wiki/Testpage#Blockquote_Test
  • A newline in the wiki markup after the opening <blockquote> tag should not result in an empty quote line in the generated html.
  • A newline in the wiki markup before the closing </blockquote> tag should not result in an empty quote line in the generated html.
  • Should functional similar to the <pre> tag.

mobile menu

On mobile there is MENU on the top right. A user has to click MENU before other linsk such as HOME DOWNLOAD, DOCS, etc. become visible. That is bad usability. Would be better if the mobile menu would be similar to the desktop menu.

Details

Impact
Normal

Event Timeline

Patrick triaged this task as Normal priority.Feb 23 2020, 5:11 PM
Patrick created this task.
Patrick updated the task description. (Show Details)

merge template footer into real footer

CSS cannot pull in or add HTML. Mediawiki's built in footer is only list of links, as far as I can tell. Therefore, a separate module is needed. Something like https://www.mediawiki.org/wiki/Extension:Header_Footer which allows a footer page to be created (multiple in fact, that target namespaces or specific pages).

remove blockquote extraneous newlines

add this css:

blockquote {
    white-space: inherit;
}

Is that the behavior you expect? I added a third test.

remove blockquote extraneous newlines

add this css:

blockquote {
    white-space: inherit;
}

Is that the behavior you expect? I added a third test.

Fixed! :)

mobile menu
is JS an option?

Not great but if there is no other option, yes. I guess JS blocking doesn't happen much on mobile, therefore ok-ish. Though, it shouldn't get worse for non-JS mobile.

merge template footer into real footer

CSS cannot pull in or add HTML.

Good to know.

Mediawiki's built in footer is only list of links, as far as I can tell. Therefore, a separate module is needed. Something like https://www.mediawiki.org/wiki/Extension:Header_Footer which allows a footer page to be created (multiple in fact, that target namespaces or specific pages).

Sounds good. I will try this somewhat soonish.

is that visually ok? Requires only one piece of css and one js

.top-bar-section ul {
width: auto !important;
}

and js

$( document ).ready(function() {
    $("#navwrapper nav:first").addClass("expanded");
});

is that visually ok? Requires only one piece of css and one js

No, that wastes too much space. Looks really unprofessional / broken.

another way, with the main menu stuff horizontal

That looks much better!

How does it look with the legal banner? Does the legal banner overlap the Whonix textual string on the top?

The Whonix textual string on the top looks like wasting too much space but I guess it will be needed due to the legal banner.