Page MenuHomePhabricator

Consider reintroducing checking of alloca() calls in STACKLEAK
Open, NormalPublic

Description

https://github.com/clipos/src_external_linux/commit/7a94313c154dfe78223729b015b16d5f257afc35

We might want to add this patch to hardened-kernel once our version catches up with STACKLEAK.

This patch was part of the original STACKLEAK patch series sent upstream but it was dropped because all VLAs were removed from the kernel so it had no purpose anymore.

This would only be useful for out-of-tree code (certain kernel modules/patches) or as a fail-safe incase VLAs are reintroduced although that’s unlikely and even more so for an LTS kernel, meaning this patch has likely very little, if any at all, advantage now.

Details

Impact
Normal

Event Timeline

madaidan created this task.Feb 11 2020, 7:06 PM
Patrick triaged this task as Normal priority.Feb 12 2020, 9:13 AM
Patrick added a project: hardened-kernel.
Patrick changed Impact from Needs Triage to Normal.