Page MenuHomePhabricator

remove kmix-disable-autostart
Closed, ResolvedPublic

Description

I suspected that kmix-disable-autostart was no longer needed as a workaround. According to it's control file description, it's there to make sure the clipboard history icon is loaded into the system tray. If that's it, it is no longer needed. To test, I removed it from meta-packages and removed the folder. I built an ova. The clipboard icon is there in the system tray and functioning normally.

Details

Impact
Needs Triage

Event Timeline

https://github.com/Whonix/kmix-disable-autostart/blob/master/usr/share/lintian/overrides/kmix-disable-autostart doesn't do anything relevant to disable autostart - besides disabling a linitian warning.

The implementation is done in https://github.com/Whonix/kmix-disable-autostart/blob/master/debian/kmix-disable-autostart.hide and by using config-package-dev.

If a new image was built without package kmix-disable-autostart and kmix didn't autostart, and kilpper is visible in systray by default, then everything should be fine indeed and kmix-disable-autostart. can be deprecated, removed from anon-meta-packages and removed from github.com/Whonix/Whonix packages folder.

We don't install kmix by default anymore anyhow, right? What mixer gets installed if any?

JasonJAyalaP added a comment.EditedOct 19 2017, 12:17 AM

We don't install kmix by default anymore anyhow, right? What mixer gets installed if any?

Ha! kmix is no longer installed by default in Debian 9. Plasma uses a native pulseaudio mixer widget thingie. I think that confirms that we can remove this package.

from the changelog.upstream of anon-meta:

Date:   Sun Jan 15 06:28:43 2017 +0000

add plasma-pa to anon-shared-applications-kde (kmix replacement)
JasonJAyalaP added a comment.EditedOct 19 2017, 12:21 AM

@Patrick I haven't removed a package from packages/ before. What is the process? Just git rm? (I've already removed it from the control file of anon-meta-packages.

JasonJAyalaP (Jason J. Ayala P.):

JasonJAyalaP added a comment.

@Patrick I haven't removed a package from packages/ before. What is the process?

grep all to see it is no longer referenced somewhere. Specifically not
from anon-meta-packages.

  1. git rm packages/pkg-name
  1. git push

Update the package description on github. (At the very top. Not part of
the readme.) Mention, that the package is deprecated since Whonix 14 and
migrated where.

Leave a note with the link to github on
https://www.whonix.org/wiki/Dev/Redistribution#Misc so we'll remove
these packages after release.

JasonJAyalaP closed this task as Resolved.Oct 19 2017, 8:13 PM
JasonJAyalaP claimed this task.