Page MenuHomePhabricator

rerunning 'make get-sources' breaks Qubes Builder
Closed, ResolvedPublic

Description

When rerunning make get-sources, it breaks for the Whonix folder (https://github.com/Whonix/Whonix).

--> Downloading additional sources for Whonix...
+ make --quiet -C qubes-src/Whonix get-sources

I could implement a dummy in makefile-generic-packages (genmkfile). Easy.

Do you think there is a more appropriate solution? And anything else that should be implemented?

(There already is an empty Makefile.builder [https://github.com/Whonix/Whonix/blob/master/Makefile.builder].)

Details

Impact
High

Event Timeline

Patrick raised the priority of this task from to High.
Patrick updated the task description. (Show Details)
Patrick added projects: Qubes, Whonix 12.
Patrick set Impact to High.
Patrick added subscribers: Patrick, marmarek, nrgaway.

qubes builder check if get-sources and verify-sources targets exist
(with make -n get-sources verify-sources), so if genmkfile creates a
wildcard one, it needs to be somehow handled. I think creating empty
(true) get-sources and verify-sources targets is ok. Or maybe you
have some better idea?