For better usability.
## --tb none|closed|open ## none: Do not install Tor Browser. ## closed: Fail closed if Tor Browser cannot be installed. ## open: Fail open if Tor Browser cannot and installed.
Failing open vs closed:
- Failing open: if Tor Browser download fails, the build continues without invoking the error handler.
- Failing closed: if Tor Browser download fails, the build invokes the error handler.
Why not fix tb-updater and make sure it does not fail?
Economically impossible. In past, TPO kept changing download locations, links, verification scheme, version format and more. I would be surprised, if tb-updater won't need to be updated in future again to cope up with their changes.
What are the reasons, why we didn't do this earlier for Whonix 10? From https://www.whonix.org/wiki/Tor_Browser#Not_installed_by_Default.
Tor Browser is not installed by default anymore. If you are interested in the reasons why, [...]
- Mozilla trademark: https://trac.torproject.org/projects/tor/ticket/10888
- The Tor Project trademark: https://www.whonix.org/wiki/Dev/TPO_Trademark
If the distributor of Qubes-Whonix, the Qubes team doesn't mind, I (@Patrick) won't mind either.
- Forces the user to get an up to date version of Tor Browser. By the time users download Whonix, mostly the shipped version of Tor Browser would be already outdated.
Could be solved by frequent releases if you're up for that. Or solved by having users manually upgrade. Then at least half of the time they have better usability.
- Users who build Whonix from source code won't have issues with a build script that is broken, just because of issues with downloading Tor Browser. [Although since Whonix 10 the build script has an option --tb open that would fail open, i.e let the build continue, even if Tor Browser download failed as opposed to --tb closed that would fail closed, i.e. invoke the usual error handler of the build script. (Default is --tb none.)]
What's your thoughts on that... Do we want the build to fail open or closed by default?