Page MenuHomePhabricator
Create Task
Maniphest T286

Only source configuration files that end with the `.conf` extension?
Closed, ResolvedPublic
Actions

Description

In T275#4134, @nrgaway wrote:

XXX: @Patrick, do your scripts ignore backed up files in directories such as /etc/whonix_firewall.d.... If not, maybe consider using a standard extension of .conf and only include those?

Files that end with ~ are ignored (backup files by many editors). Files that end with .dpkg-* are ignored (file names used by dpkg conflict resolution). So you could rename these files for example to .dpkg-nouse.

Do we want to rename all the config files to include a .conf extension and then only source those? Any opinions?

Existing documentation:
https://www.whonix.org/wiki/Whonix_Configuration_Files

The config folder sourceing code for whonix-gw-firewall be viewed here:
https://github.com/Whonix/whonix-gw-firewall/blob/master/usr/bin/whonix_firewall#L27
https://github.com/Whonix/whonix-gw-firewall/blob/5ebca43416269a5fd42c98a80af1b0b3d38adecf/usr/bin/whonix_firewall#L27

Others for whonixcheck etc. look similar.

Details

Impact
Normal

Related Objects

Event Timeline

Patrick created this task.Apr 29 2015, 2:01 PM
Patrick raised the priority of this task from to Normal.
Patrick updated the task description. (Show Details)
Patrick added projects: Whonix 11, whonix-gw-firewall, whonix-ws-firewall, whonixcheck, sdwdate, whonix-repository, build, uwt, onion-grater (Control Port Filter Proxy).
Patrick set Impact to Normal.
Patrick added subscribers: Patrick, HulaHoop, nrgaway and 2 others.
Herald added a project: Whonix. · View Herald TranscriptApr 29 2015, 2:01 PM
Patrick mentioned this in T275: Qubes Whonix 9.6.9 and 10.0.5 is ready.Apr 29 2015, 2:02 PM
Patrick edited projects, added Whonix 12; removed Whonix 11.May 16 2015, 6:11 AM
Patrick edited projects, added Whonix 13; removed Whonix 12.Aug 19 2015, 7:58 PM
Patrick removed a project: whonix-repository.Nov 30 2015, 7:53 PM
Patrick added a project: rads.Nov 30 2015, 8:03 PM
Patrick added projects: Whonix-Host, open-link-confirmation.Nov 30 2015, 8:33 PM
Patrick added projects: tb-starter, tb-updater.Nov 30 2015, 8:38 PM
Patrick added a comment.Nov 30 2015, 8:56 PM
Only source configuration files that end with the '.conf' extension.

Thanks to @nrgaway for the suggestion!

https://phabricator.whonix.org/T286

https://github.com/Whonix/control-port-filter-python/commit/4280a718558f776bfac8b5b2fce3a13bd021fe5c @troubadour
https://github.com/Whonix/open-link-confirmation/commit/0b6c0f212df08fb4fae06c86cc0abbab6abfdbb5
https://github.com/Whonix/qubes-whonix/commit/8282d2cef8cb8a22033594a1164395373e4dfced
https://github.com/Whonix/rads/commit/9e462bbe39fe5dfbcf9ed841c482803a21c9fd24
https://github.com/Whonix/sdwdate/commit/47e9a0eb84fd184ac799b0d48b9ccc67d55db747 @troubadour
https://github.com/Whonix/tb-starter/commit/d4c9822e6c08a15c89d2aa02dc60fd59cb6f3996
https://github.com/Whonix/tb-updater/commit/9ee254e4ab2deabe85953ba00f5dd4e829545cfa
https://github.com/Whonix/uwt/commit/4dd48f16329d9701d8d86c3dc4931251a15372c6
https://github.com/Whonix/whonix-gw-firewall/commit/eafa4a9f7ec30b706597c88fccd22506691dfb69
https://github.com/Whonix/whonix-ws-firewall/commit/24baec332e1040056888cd0522760b4134b2920a
https://github.com/Whonix/whonix-host-firewall/commit/e6caaa761b2a08569419a2c9756d133452fd256a
https://github.com/Whonix/whonixcheck/commit/afe9aad6aa25e7577442478ce8f1117b76f86bfe

Can you please check the onion-grater (Control Port Filter Proxy) and sdwdate commits? @troubadour?

Patrick changed the task status from Open to Review.Nov 30 2015, 10:55 PM

https://github.com/Whonix/Whonix/commit/1340726a83e5e02fe5e355cd20620d04335024c4

Patrick changed the task status from Review to Open.Apr 28 2016, 4:49 AM

Since T503 is not yet implemented, Whonix 12 -> Whonix 13 are currently broken because of uwt. whonix-repository and tb-updater fails closed because the moment it uses gpg, /etc/uwt.d/30_uwt_default.conf does not exist, which results in "gpg" (actually uwt) failing. The solution I will be attempting is to make uwt also work with built-in defaults (part of T503).

Patrick changed the task status from Open to Review.Apr 28 2016, 5:07 AM

https://github.com/Whonix/uwt/commit/651d2af8417fb0b7f77a88493a37935972ed444b

Patrick added a comment.Apr 29 2016, 2:50 AM
In T286#8987, @Patrick wrote:

https://github.com/Whonix/uwt/commit/651d2af8417fb0b7f77a88493a37935972ed444b

Works.

Patrick added a comment.Apr 29 2016, 5:55 AM

https://github.com/Whonix/sdwdate/commit/0a0436b2de152ca13445c368fbd7cb95d339c75a

Patrick closed this task as Resolved.Apr 29 2016, 5:55 AM
Patrick claimed this task.
Whonix OLD Issue Tracker · PLEASE DO NOT POST NEW TICKETS HERE · OLD Issue Tracker - Unread Notifications · OLD Issue Tracker - Feed · OLD Issue Tracker - Open Issues · NEW Issue Tracker · Homepage · Blog · Forum · Legal · Imprint · Privacy Policy · Terms of Use · Disclaimer