Page MenuHomePhabricator

whonixcheck workaround can be removed in qubes-whonix 10
Closed, ResolvedPublic

Description

https://github.com/QubesOS/qubes-linux-template-builder/blob/master/scripts_debian/wheezy%2Bwhonix/02_install_groups_packages_installed.sh#L248

# Prevent whonixcheck error
echo 'WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER="1"' >> "${INSTALLDIR}/etc/whonix.d/30_whonixcheck_default"

Can be removed.

That should be fixed in whonixcheck that comes with Whonix 10. I think we discussed/fixed this elsewhere already but not sure. If you get this updated file for testing, it should work out of the box:
https://github.com/Whonix/whonixcheck/blob/master/usr/lib/whonixcheck/check_virtualizer

As a side note, generally, when having the ".d" mechanism (https://www.whonix.org/wiki/Whonix_Configuration_Files#.d_style_configuration_folders) it's best not to touch the original file but to ship one that overrules the default setting. (Higher number named file.)

Event Timeline

Patrick created this task.Mar 24 2015, 3:36 PM
Patrick updated the task description. (Show Details)
Patrick raised the priority of this task from to Normal.
Patrick added projects: qubes-whonix 10, Qubes.
Patrick added subscribers: Patrick, nrgaway, WhonixQubes.
Patrick assigned this task to nrgaway.Jun 11 2015, 5:09 AM

Looks like you done this, @nrgaway?

Its now in etc/whonix.d/40_qubes:WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER="1"
since I was still getting those errors in Whonix 10.

You saying I should not have? Guess we could try removing it for Whonix 11?

In T248#5442, @nrgaway wrote:

Its now in etc/whonix.d/40_qubes:WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER="1"
since I was still getting those errors in Whonix 10.

That's better.

You saying I should not have? Guess we could try removing it for Whonix 11?

The right thing is to fix it upstream in whonixcheck, no? It should be fixed upstream in whonixcheck already. I remember discussing this with WhonixQubes and fixing this. (check_virtualizer script)

For a quick test:

  • no rebuild required
  • (Temporarily) remove the WHONIXCHECK_NO_EXIT_ON_UNSUPPORTED_VIRTUALIZER setting.
  • Run: whonixcheck --function check_virtualizer | Expected result: nothing
  • Run: whonixcheck --verbose --function check_virtualizer | Expected result: supported virtualizer

Otherwise it should be fixed upstream in whonixcheck for qubes-whonix 12.