Page MenuHomePhabricator

control-port-filter-python improvement
Closed, ResolvedPublic

Description

So we have an expert opinion (https://mailman.boum.org/pipermail/tails-dev/2015-March/008461.html) on control-port-filter in Whonix. It looks like we could work on improving cpfp.py.

I was expecting some of the points (especially the depth of if's in the configuration file parsing). I'll see to that point by point.

About logging, would it be an advantage to use syslog or systemd journal instead of a dedicated log file? For debugging, it seems better to keep it separate.

Details

Impact
Needs Triage

Event Timeline

troubadour raised the priority of this task from to Normal.
troubadour updated the task description. (Show Details)
troubadour added a subscriber: troubadour.

Great!

My answer, that also "answers" the logging one by asking questions:
https://mailman.boum.org/pipermail/tails-dev/2015-March/008471.html

Some commits.

You are missing a dot here:

selfDISABLE_FILTERING = False

Works for me. Merged.

Nice and merged.

Can the Whonix 10 tag be removed?

Patrick set Impact to Needs Triage.

Is there anything left to do here?

Patrick closed this task as Resolved.Sep 23 2016, 2:18 AM
Patrick claimed this task.
Patrick reassigned this task from Patrick to troubadour.