Page MenuHomePhabricator
Create Task
Maniphest T187

Architecture: "any" vs "all", i386, platforms support
Closed, ResolvedPublic
Actions

Description

Unless there are any objections, I think we should change in debian/control from.

Architecture: any

That would create a file qubes-whonix_9.7-1_i386.deb. To...

Architecture: all

That creates a file qubes-whonix_9.7-1_all.deb.

Why?

  • It's not i386 dependent.
  • If anything, surely it's not i386?
  • It's not dependent on any platform.
  • We like to add a all package to the repository. (T182)
  • Causes issues with makefile-generic-packages that currently hardcodes all. (Maybe that's a bug that should be fixed for Whonix 11 ?)
  • High priority, because it currently breaks Whonix's build script.

Related Objects
Search...

Event Timeline

Patrick created this task.Feb 17 2015, 7:18 AM
Patrick raised the priority of this task from to High.
Patrick updated the task description. (Show Details)
Patrick added a project: Qubes.
Patrick added subscribers: Patrick, nrgaway, • WhonixQubes.
Herald added a project: Whonix. · View Herald TranscriptFeb 17 2015, 7:18 AM
Herald added a subscriber: troubadour. · View Herald Transcript
Patrick changed the task status from Open to Review.Feb 17 2015, 7:21 AM

Done:
https://github.com/Whonix/qubes-whonix/commit/5a13ac2617c974128cfb2b3b4c0613cb91ca3cfd

Please review.

• WhonixQubes added a comment.Feb 17 2015, 7:49 AM

Looks good to me.

Patrick added a parent task: T182: Add qubes-whonix 9.6.2-1 to Whonix APT Repository.Feb 18 2015, 2:48 PM
nrgaway added a comment.Feb 18 2015, 9:19 PM

I will test it out here but do not see any issues with it at the moment

nrgaway added a comment.Feb 22 2015, 8:11 PM

I changed Architecture in the control file to all https://github.com/nrgaway/qubes-whonix/commit/e52bc1e577dbfef08a0d564961b5a72ccce8a59b (Git commit message is mis-labelled; says I changed it from all to any when I really changed it from any to all :)

You are correct as the files are building and create a file similar to qubes-whonix_9.7-1_all.deb. I actually believe though that the former any may be more correct if there are any packages that may be hardware dependant since in that case builds need to be compiled against the multi-architectures When built via qubes-builder with the Architecture set to any the file that is created looks like this: qubes-whonix_9.7-1_amd64.deb as it was built within an amd64 environment.

In our case there would not be much of an issue since there is no hardware dependent scripts contained within qubes-whonix so all would be most correct in this scenario I would agree.

Looks like this issue can be removed as a blocker now?

Patrick closed this task as Resolved.Feb 22 2015, 10:13 PM
Patrick claimed this task.

If you merged
https://github.com/Whonix/qubes-whonix/commit/5a13ac2617c974128cfb2b3b4c0613cb91ca3cfd then there would have been no need for https://phabricator.whonix.org/T187 but nevermind.

Can be considered resolved, as always, feel free to reopen.

Whonix OLD Issue Tracker · PLEASE DO NOT POST NEW TICKETS HERE · OLD Issue Tracker - Unread Notifications · OLD Issue Tracker - Feed · OLD Issue Tracker - Open Issues · NEW Issue Tracker · Homepage · Blog · Forum · Legal · Imprint · Privacy Policy · Terms of Use · Disclaimer