Page MenuHomePhabricator

many lintian warnings in qubes-whonix package
Closed, ResolvedPublic

Description

As of qubes-whonix 731e3e8ab0a5958341a96c4d4877b72ea0084209:

+ lintian --pedantic --info --display-info --fail-on-warnings
I: qubes-whonix: output-of-updaterc.d-not-redirected-to-dev-null tor postinst
N: 
N:    The output messages of the update-rc.d command should be redirected to
N:    /dev/null because it is currently very chatty per default.
N:    
N:    Severity: wishlist, Certainty: certain
N:    
N:    Check: init.d, Type: binary
N: 
I: qubes-whonix: output-of-updaterc.d-not-redirected-to-dev-null sdwdate postinst
I: qubes-whonix: output-of-updaterc.d-not-redirected-to-dev-null network-manager postinst
I: qubes-whonix: output-of-updaterc.d-not-redirected-to-dev-null spice-vdagent postinst
I: qubes-whonix: output-of-updaterc.d-not-redirected-to-dev-null swap-file-creator postinst
I: qubes-whonix: output-of-updaterc.d-not-redirected-to-dev-null whonix-initializer postinst
E: qubes-whonix: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/spice-vdagent
N: 
N:    An /etc/init.d script which has been registered in the postinst script
N:    is not de-registered in the postrm script.
N:    
N:    Refer to Debian Policy Manual section 9.3.3.1 (Managing the links) for
N:    details.
N:    
N:    Severity: important, Certainty: certain
N:    
N:    Check: init.d, Type: binary
N: 
E: qubes-whonix: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/sdwdate
E: qubes-whonix: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/whonix-initializer
E: qubes-whonix: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/swap-file-creator
E: qubes-whonix: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/network-manager
E: qubes-whonix: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/tor
W: qubes-whonix: init.d-script-not-marked-as-conffile etc/init.d/spice-vdagent
N: 
N:    /etc/init.d scripts should be marked as conffiles.
N:    
N:    This is usually an error, but the Policy allows for managing these files
N:    manually in maintainer scripts and Lintian cannot reliably detect that.
N:    
N:    Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
N:    details.
N:    
N:    Severity: important, Certainty: wild-guess
N:    
N:    Check: init.d, Type: binary
N: 
E: qubes-whonix: init.d-script-not-included-in-package etc/init.d/spice-vdagent
N: 
N:    The /etc/init.d script is registered in the postinst script, but is not
N:    included in the package.
N:    
N:    Severity: important, Certainty: certain
N:    
N:    Check: init.d, Type: binary
N: 
W: qubes-whonix: init.d-script-not-marked-as-conffile etc/init.d/sdwdate
E: qubes-whonix: init.d-script-not-included-in-package etc/init.d/sdwdate
W: qubes-whonix: init.d-script-not-marked-as-conffile etc/init.d/whonix-initializer
E: qubes-whonix: init.d-script-not-included-in-package etc/init.d/whonix-initializer
W: qubes-whonix: init.d-script-not-marked-as-conffile etc/init.d/swap-file-creator
E: qubes-whonix: init.d-script-not-included-in-package etc/init.d/swap-file-creator
W: qubes-whonix: init.d-script-not-marked-as-conffile etc/init.d/network-manager
E: qubes-whonix: init.d-script-not-included-in-package etc/init.d/network-manager
W: qubes-whonix: init.d-script-not-marked-as-conffile etc/init.d/tor
E: qubes-whonix: init.d-script-not-included-in-package etc/init.d/tor
W: qubes-whonix: script-not-executable etc/uwt.d/32_qubes
N: 
N:    This file starts with the #! sequence that marks interpreted scripts,
N:    but it is not executable.
N:    
N:    Severity: normal, Certainty: certain
N:    
N:    Check: scripts, Type: binary
N: 
E: qubes-whonix: python-script-but-no-python-dep usr/lib/qubes-whonix/alert
N: 
N:    Packages with Python scripts should depend on the package python. Those
N:    with scripts that specify a specific version of Python must depend on
N:    that version of Python (exactly).
N:    
N:    For example, if a script in the package uses #!/usr/bin/python, the
N:    package needs a dependency on python. If a script uses
N:    #!/usr/bin/python2.6, the package needs a dependency on python2.6. A
N:    dependency on python (>= 2.6) is not correct, since later versions of
N:    Python may not provide the /usr/bin/python2.6 binary.
N:    
N:    If you are using debhelper, adding ${python:Depends} to the Depends
N:    field and ensuring dh_pysupport or dh_pycentral are run during the build
N:    should take care of adding the correct dependency.
N:    
N:    In some cases a weaker relationship, such as Suggests or Recommends,
N:    will be more appropriate.
N:    
N:    Severity: important, Certainty: certain
N:    
N:    Check: scripts, Type: binary
N: 
E: qubes-whonix: python-script-but-no-python-dep usr/lib/qubes-whonix/init/replace-ips
W: qubes-whonix: script-not-executable usr/lib/qubes-whonix/utility_functions.sh
W: qubes-whonix: maintainer-script-ignores-errors preinst
N: 
N:    The maintainer script doesn't seem to set the -e flag which ensures that
N:    the script's execution is aborted when any executed command fails.
N:    
N:    Refer to Debian Policy Manual section 10.4 (Scripts) for details.
N:    
N:    Severity: normal, Certainty: certain
N:    
N:    Check: scripts, Type: binary
N: 
W: qubes-whonix: maintainer-script-ignores-errors postrm
W: qubes-whonix: maintainer-script-ignores-errors prerm
W: qubes-whonix: maintainer-script-ignores-errors postinst
N: 2 tags overridden (2 warnings)

Most of these warnings have already been reported by me in separate tickets.

There could be a few disagreements about some of them. Anyhow.

A few are easy to fix (maintainer-script-ignores-errors...).

Details

Impact
Needs Triage