Page MenuHomePhabricator

implement deb-pkg-build-dep and deb-pkg-update-build-dep
Closed, ResolvedPublic

Event Timeline

Patrick created this task.Feb 15 2015, 11:50 AM
Patrick raised the priority of this task from to Normal.
Patrick updated the task description. (Show Details)
Patrick added subscribers: Patrick, WhonixQubes, nrgaway.
Patrick closed this task as Resolved.Feb 15 2015, 2:34 PM
Patrick claimed this task.

Done,
implemented make deb-build-dep. Install build dependencies listed in debian/control under Build-Depends using apt-get. Various environment variables supported.:
https://github.com/Whonix/Whonix/commit/5883fbdbbf8729f0d474e18231cde0bf2713f4e8

I didn't implement running apt-get update beforehand, because securely running apt-get update in scripts is very difficult due to unreliability of exit codes. (See: https://www.whonix.org/wiki/Dev/apt-get#Bugs) It would be best if running apt-get update was left to the user or the build script that builds the package (such as Whonix's or Qubes's build script).

(Whonix's build script checks for apt-get update gpg failures in help-steps/pre, function aptgetgpgvcreatetmp and function aptgetgpgvparsetmp. apt-get update network failures: T169)

Another limitation is, that it does not check the version numbers of the build dependencies. Installs those from the repository, that you apt-get updated beforehand. Isn't able to resolve or fetch packages if download from newer (such as testing) repository is required. That would require more implementation effort. I think that is also the reason, why I didn't implement make deb-build-dep any earlier.